Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Django version to 2.2.7 #58

Open
sabrown89 opened this issue Nov 8, 2019 · 9 comments
Open

Upgrade Django version to 2.2.7 #58

sabrown89 opened this issue Nov 8, 2019 · 9 comments

Comments

@sabrown89
Copy link
Collaborator

The current Django version == 1.11.3 which is incompatible with python 3.7 . Upgrade the Django version in the requirements.txt file to 2.2.7 and verify all tests are passing and the app builds properly.

@sabrown89
Copy link
Collaborator Author

I am working on this!

@pryelluw
Copy link
Member

pryelluw commented Nov 8, 2019

OK, thank you. I was about to start working on it.
Please make note of the incoming pull request from me. :)

@pryelluw
Copy link
Member

Can we get an update of this item?
If you are not able to complete it please let me know. I'll take ownership of it.

@pryelluw
Copy link
Member

@sabrown89

@sabrown89
Copy link
Collaborator Author

Hey, I was waiting for your PR to merged in as you noted above. I can go ahead and make a PR for the repository as it stands (without your PR pulled in) if you prefer that.

@pryelluw
Copy link
Member

Let's wait till the PR gets merged. It's simpler all around.
Do you have a link to a repo with the changes?
Im writing new code and that would help keep things in line :)

@sabrown89
Copy link
Collaborator Author

Sounds good!
I'll comment with a link by tomorrow.

@pryelluw
Copy link
Member

@sabrown89

I've decided to leave podium alone and create a different django app.

I'm going to reuse most of the code I wrote (aside for updating it to the newer django version).
I do not want to waste your efforts. What should we do to avoid that? I'm not merging the code I wrote into Podium. Could you push your code to a different repo and I can copy from it? LMK! :)

@sabrown89
Copy link
Collaborator Author

@pabloriveracelerity Sounds good! All I've done is change the requirements.txt file so the dependencies work with Django 2.2.7 and the runserver builds. I didn't change any of the url paths or anything else like that. Please see below:

dj-database-url==0.4.2
Django==2.2.7
gunicorn==19.7.1
psycopg2==2.7.1
python-dotenv==0.6.4
whitenoise==3.3.0
django-crispy-forms==1.8.0
django-registration-redux==2.5

Should I open a PR with these changes for Podium (excluding your PR)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants