Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: review issue link is not rendering on our packages cards #525

Closed
lwasser opened this issue Nov 21, 2024 · 4 comments
Closed

BUG: review issue link is not rendering on our packages cards #525

lwasser opened this issue Nov 21, 2024 · 4 comments
Labels
bug Something isn't working high-priority Things we'd like to prioritize working on

Comments

@lwasser
Copy link
Member

lwasser commented Nov 21, 2024

Jekyll is not recognizing the issue_link field and rendering that field in our badges for some reason. You can see this in our packages page where the code is there to render the issue link but it's not actually rendering.

https://www.pyopensci.org/python-packages.html

all packages should have a link to the review issue associated with it.

Screenshot 2024-11-20 at 5 23 18 PM
@lwasser
Copy link
Member Author

lwasser commented Jan 7, 2025

@erik-whiting you are right. this issue has been addressed. i probably forgot to reference it in the pr that fixed things! let's close!! 🚀 thank you !!

@lwasser lwasser closed this as completed Jan 7, 2025
@lwasser
Copy link
Member Author

lwasser commented Jan 7, 2025

@all-contributors please add @erik-whiting for review

Copy link
Contributor

@lwasser

I've put up a pull request to add @erik-whiting! 🎉

@erik-whiting
Copy link
Contributor

@erik-whiting you are right. this issue has been addressed. i probably forgot to reference it in the pr that fixed things! let's close!! 🚀 thank you !!

my PR also attempts to fix #526, is that bug still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority Things we'd like to prioritize working on
Projects
None yet
Development

No branches or pull requests

2 participants