Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: oversized quotes on blog obscure text on mobile and desktop #479

Closed
kierisi opened this issue Sep 5, 2024 · 1 comment · Fixed by #481
Closed

BUG: oversized quotes on blog obscure text on mobile and desktop #479

kierisi opened this issue Sep 5, 2024 · 1 comment · Fixed by #481
Labels
bug Something isn't working

Comments

@kierisi
Copy link
Contributor

kierisi commented Sep 5, 2024

Describe the bug
the oversized quotes used in this blog post obscure the text on both mobile and desktop. on desktop this can largely be mitigated by increasing the window size, however there are cases where the text is too long and window size no longer corrects for the issue (example included in screenshot below).

To Reproduce
Steps to reproduce the behavior:

  1. Go to this post on mobile and desktop: https://www.pyopensci.org/blog/what-pyopensci-accomplished-with-two-years-of-funding.html

Expected behavior
To read the text without images obscuring it

Screenshots
If applicable, add screenshots to help explain your problem.
Mobile example:
mobile-issue

Desktop example:
Screenshot 2024-09-05 at 10 54 24 AM

Desktop (if issue was encountered on a desktop):

  • OS with version: macOS Sonoma 14.4.1
  • Browser: Chrome, Safari, Firefox

Mobile (if issue was encountered on a mobile device):

  • Device: iPhone 15 Pro

  • OS with version: iOS 17.5.1

  • Browser Safari

  • Device: Google Pixel 6

  • OS with version:

  • Browser Chrome, Firefox

@kierisi kierisi added the bug Something isn't working label Sep 5, 2024
@willingc
Copy link
Collaborator

willingc commented Sep 6, 2024

Doing a very quick check it looks as if blockquote in CSS is not enclosing the quote marks, quote, and author into the same container.

This seems like a good file to start with: _includes/pyos-blockquote.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants