Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create pr with upstream remote now works #775

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Dronakurl
Copy link
Contributor

@Dronakurl Dronakurl commented Jan 2, 2025

Describe what this PR does / why we need it

I wanted to create a pull request with octo, but for some reason there was a message displayed, that the current branch has no remote and if I wanted to push the current one.
The reason was that the command pulls remote branches from the remote that takes precedence.
That is the upstream repo. Therefore, the local branch of course does not exist in that remote.

Does this pull request fix one issue?

Fixes #400

Describe how you did it

I changed the pr create command so that it first tries to get from the remote origin not according to the precedence.

Describe how to verify it

This very PR was created with Octo :-)

Special notes for reviews

Checklist

  • Passing tests and linting standards

@Dronakurl Dronakurl marked this pull request as draft January 2, 2025 11:27
Copy link
Collaborator

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's go for it! Thanks for the PR

@wd60622 wd60622 marked this pull request as ready for review January 2, 2025 11:53
@wd60622 wd60622 merged commit 59303c8 into pwntester:master Jan 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR creation doesn't recognize remote branch
2 participants