Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display merge state in PR #666

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

macovsky
Copy link
Contributor

@macovsky macovsky commented Nov 3, 2024

Describe what this PR does / why we need it

Following up on #660 adds "Merge" section to PR view—it's nice to see if you can merge with commit or squash/rebase, etc).

I capitalized checks message as well, IMO it looks good:

2024-11-03_09-48
2024-11-03_09-48_1
2024-11-03_09-49

Does this pull request fix one issue?

NONE

Describe how to verify it

See different PRs with no reviews, conflicts, etc.

Checklist

  • Passing tests and linting standards
  • Documentation updates in README.md and doc/octo.txt

if mergeable is MERGEABLE then we go into mergeStateStatus for details,
otherwise display either CONFLICTING or PENDING
@pwntester pwntester merged commit 87c1a07 into pwntester:master Nov 4, 2024
2 checks passed
@pwntester
Copy link
Owner

Thanks for the PR @macovsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants