use "comment" over "comments" in review buffer #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if there's one comment
wd60622
reviewed
Oct 30, 2024
wd60622
reviewed
Oct 30, 2024
hm, I tried multiple times and couldn't see "comments" anywhere, it just appears as "comment" for me right from the start. did you see it as "1 comments" or maybe even "0 comments"?
idk really, just looked in the code and couldn't find anything related |
wd60622
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Displays "comment" in review buffer instead of "comments"
Does this pull request fix one issue?
Fixes #648
Describe how you did it
Describe how to verify it
Make a comment in your review and see that it's displayed as "1 comment" in diff
Special notes for reviews
Checklist