Add discussion list support

[wd60622]

Ability to list discussions for a repository

Adds the discussion list command

Related to #239

[wd60622]

:Octo discussion list command

Currently there is not a buffer that supports interacting with discussion but user can view in the previewer and for URL

[pwntester]

Thanks for adding support for discussions @wd60622 Do you want to merge this in before adding a discussion type of buffer? Im ok with showing the preview only and maybe opening it a browser on <CR> for now (until a dedicated octo buffer type is created)

[wd60622]

Thats my idea as well. i can break it down a bit more a create issues for it. Currently the <CR> copies the number to register. <C-y> works for url. I havent figured out the how to open discussion in browser just yet. Is that desired <CR> behavior?

[pwntester]

From a UX point of view, I think users may expect to "enter" the discussion when pressing CR. If we cant show it in a buffer for now, I think the behaviour that would make more sense is to open it in a browser. You can use https://github.com/pwntester/octo.nvim/blob/master/lua/octo/navigation.lua#L12-L23 for it

[wd60622]

From a UX point of view, I think users may expect to "enter" the discussion when pressing CR. If we cant show it in a buffer for now, I think the behaviour that would make more sense is to open it in a browser. You can use https://github.com/pwntester/octo.nvim/blob/master/lua/octo/navigation.lua#L12-L23 for it

Great. I will get to it when I can!

[wd60622]

Hi @pwntester, thank you for the review. I have added the open in browser functionality. Please take a look and see if it works on your end. I will begin to make some issues for the next steps.

[pwntester]

Works great, thanks!