fix(repo parsing): considers cases where git repo has a trailing / #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwntester
requested changes
Sep 14, 2024
the automatic repository finding (when none passed as args) wouldn't work when the return of `git remote -v` had a trailing '/' parser would split the lines with '/' as a delimiter. the trailing '/' made the result be an array of length 4 which wasn't considered.
pwntester
approved these changes
Sep 14, 2024
|
Thanks @Hashino can you please fix the linting errors? |
pwntester
approved these changes
Sep 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
the automatic repository finding (when none passed as args) wouldn't work when the return of
git remote -vhad a trailing '/'. this is reproducible by adding a trailing '/' when cloning a repositoryparser would split the lines with '/' as a delimiter. the trailing '/' made the result be an array of length 4 which wasn't considered.
Does this pull request fix one issue?
Fixes #605
Describe how you did it
added condition for when the split segments has a length of 4.
Describe how to verify it
Special notes for reviews
additional checking that
segment[4] == nilcould be added to ensure this change fixes only this edge casethe opposite approach could be made and use
if #segments > 2so it becomes the default behavior for more edge cases