Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not show outdated comments in review #600

Merged

Conversation

GuillaumeLagrange
Copy link
Collaborator

@GuillaumeLagrange GuillaumeLagrange commented Sep 12, 2024

Does this pull request fix one issue?

Fixes #599

@GuillaumeLagrange GuillaumeLagrange force-pushed the hide-outdated-comments-in-review branch from 26693e5 to fbdea7a Compare September 27, 2024 11:25
@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review September 27, 2024 11:26
@GuillaumeLagrange
Copy link
Collaborator Author

@pwntester after a few weeks of usage, I think it makes reviewing PRs multiple times much more enjoyable, any thoughts about this ?

Copy link
Collaborator

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a configuration option?

@GuillaumeLagrange
Copy link
Collaborator Author

It could be nice, but over-configurability is a thing that I'd like to avoid if possible 🤔

Copy link
Collaborator

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good then!

@wd60622 wd60622 merged commit 896d48b into pwntester:master Oct 15, 2024
2 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the hide-outdated-comments-in-review branch November 9, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide outdated comments in review mode
2 participants