-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use repo assignable / mentionable users in finder #594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to move the shared code to a shared location so other pickers can reuse it. But since there is no other implementation for fzf-lua yet, Im ok if you want to merge this and let the implementator for fzf-lua to refactor that code.
@milogert just a heads up about a new implementation of the picker for choosing users in case you can port it to fzf-lua |
Might be good to add to the readme before merge if you think this config change is reasonable @pwntester |
Yep, please update the docs so users know the three options and the differences between them |
I've added to the README. Let me know what you think about the location @pwntester |
That should be enough, thanks! |
Tested the integration on my config. You guys rule! It is a banger and the documentation is crystal clear. |
Thanks @wd60622! |
Thanks! I can start taking a look at this 👌 |
Describe what this PR does / why we need it
Use repo's assignable / mentionable users to populate finder instead of general GitHub search.
TODO:
Does this pull request fix one issue?
Closes #423
Describe how you did it
Pull out the finder creation logic
Describe how to verify it
Use
Octo assignee add
orOcto reviewer add
to see the new behavior.Special notes for reviews