Add keymaps for start, resume, submit and discard Reviews #498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
The process of opening a pull-request and starting a review was a little disconnected, as we had keymaps to almost everything we can do with a pull-request, except for starting a review.
review-keymaps.mp4
Describe how you did it
I followed the project standard and created named mappings that mirror the configuration keys and added them to:
pull_reqest
)review_diff
)file_pane
)The new commands are:
review_start
<leader>vs
review_resume
<leader>vr
submit_review
<leader>vs
discard_review
<leader>vd
Describe how to verify it
Start and resume a PR:
<leader>vs
to start a reviewCtrl+c
to close the review<leader>vr
to resume the reviewSubmit or discard a PR
<leader>vs
to start a review<leader>vs
to open the submit modal:q
to close it<leader>vd
to discard the review, you should see a prompt asking to confirm.Special notes for reviews
Aside from the keybindings, this PR also fixed the
Ctrl+C
to close the review, that wasn't working, as it wasn't passing the current tab as an argument to theclose()
function, so the key press was just ignored.