Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems fzf-lua picker dont have actions.mappings for 'send selected items into quickfix'? #517

Open
MadKuntilanak opened this issue Mar 15, 2024 · 3 comments · May be fixed by #527
Open
Assignees
Labels
bug Something wrong in the code fzf Related to fzf

Comments

@MadKuntilanak
Copy link

MadKuntilanak commented Mar 15, 2024

Issue Description

Type: feature request

Describe what happened (or what feature you want)

Sending selected items into quickfix with telescope its okay, but not with fzf-lua?

milogert added a commit to milogert/octo.nvim that referenced this issue Mar 18, 2024
Fixes pwntester#517

In some cases multiselect to send to the quickfix list makes sense. This
enables that functionality.
@milogert
Copy link
Contributor

@pwntester Had a question about this: I added sending to quickfix in a branch ☝️ by just tabbing over entries and hitting enter. That generally works.

But I was also considering adding when you tab over entries (i.e. select them) and then hit ctrl-v it would open all of them in vertical splits (same with ctrl-s for horizontal splits and ctrl-t for tabs). All of this is standard functionality for how fzf-lua operates.

The problem I'm running into is only the final split gets any real content and if you slow down the screen recording below you can see that all three issues get loaded in sequence in a single buffer.

octo.nvim.517.mov

Do you have any ideas about this? Also, when opening in the quickfix window if you select an item (rather than using :cnext etc) it will create a new split.

@pwntester
Copy link
Owner

@milogert how do you handle opening multiple files? I can only see the QF bits in your branch. As for QF, this is handled by Telescope so you may want to take a look to see how thats implemented there (it may be handled by the autocmds defined there)

@milogert
Copy link
Contributor

@pwntester thanks for looking. I revisited this yesterday and I think I found a solution to this whole ticket.. But I also think there is a bug in fzf-lua (maybe) that involves setting uris as files when sending to quickfix. I'm going to open a PR over there and see what they think

If that bug is actually a bug and not by design I think it will simplify all of the fzf-lua picker actions since we'd be able to just use the natively provided fzf-lua actions instead of custom ones (at least for basic stuff, ctrl-y and ctrl-b would still need to be custom)

@milogert milogert linked a pull request Mar 25, 2024 that will close this issue
@wd60622 wd60622 added fzf Related to fzf bug Something wrong in the code labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something wrong in the code fzf Related to fzf
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants