Any way to prevent LSP from trying to attach in octo buffers?

[joshpetit]

Octo is awesome! One thing that's a bit annoying though are the consistent errors from my lsp trying to attach to the octo buffers when reviewing. I consistently get this error:

LSP[dartls] URI was not a valid file:// URI

Is there some way to make the lsp not attach to the octo buffers?

[pwntester]

I use something like: https://github.com/pwntester/dotfiles/blob/master/config/nvim/lua/pwntester/lsp.lua#L139-L144 to prevent LSP from attaching to special buffers

[joshpetit]

Hm, does this work for every language server? It seems to not through exceptions for the dartls, but for tsserver it does. My dartls still attaches though 😅. I could look into this more later but it doesn't stop me from using octo which makes it ok.

[Davincible]

@pwntester on the contrary, is LSP supposed to attach by default? It doesn't for me but I would like to have my LSP when doing reviews

[delabere]

I would really like to be able to use my LSP when looking at PR reviews after checking out the review branch locally. I can see in the top post on this reddit thread that OP (@pwntester) says it's possible to do so?

Any way this is possible?

[NWVi]

@delabere @Davincible If you want to be able to use your LSP when looking at PR reviews you can uncomment the opts.use_local check found here:

octo.nvim/lua/octo/reviews/file-entry.lua

Line 394 in b75630f

--if opts.use_local then

I believe it was changed to support commit based review per the commit that removed it: c3508b5

I created a fork where I made this change if you want to use it.
https://github.com/NWVi/octo.nvim

[pwntester]

Yep, exactly, I think it would be good to make a config option so you could use the contents from the file system (will require changing branches and that change may not be reverted depending on how vim is exited) or use it from git store. @NWVi, would you be able to send a PR for this?

[NWVi]

@pwntester I made an attempt at a PR for this. My implementation might be a little naive, and does not revert changing branches after review or exiting vim if the user accepts the PR branch checkout.

#349

[pwntester]

Awesome! thanks!