Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorretc result for message endingwith 0. #4

Open
jbadura opened this issue Dec 2, 2024 · 0 comments
Open

Incorretc result for message endingwith 0. #4

jbadura opened this issue Dec 2, 2024 · 0 comments

Comments

@jbadura
Copy link

jbadura commented Dec 2, 2024

Server returns 'All good!' when message ends with byte 0.

cbc.zig, from line 73:

// Check padding
// Return length of message if ok, otherwise 0.
const pad_length: u8 = dst[i - 1];

if (pad_length == 0) {
    return 0;
}

if (pad_length > block_length) {
    return 0;
}
var j: usize = 0;
while (j < pad_length) : (j += 1) {
    if (dst[i - j - 1] != pad_length) {
        return 0;
    }
}
return i - pad_length;

I think you should add:

if (pad_length == 0) {
    return 0;
}
JSzyba pushed a commit that referenced this issue Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant