New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how to render and hydrate namespaces elements and attributes #43

Open

srghma opened this issue Jul 31, 2020 · 1 comment

srghma commented Jul 31, 2020

here is the code from next.js example

here is how nextjs rendered html

here are relevant react code parts

https://github.com/facebook/react/blob/b87aabdfe1b7461e7331abb3601d9e6bb27544bc/packages/react-dom/src/shared/DOMNamespaces.js#L8-L10

https://github.com/facebook/react/blob/3e94bce765d355d74f6a60feb4addb6d196e3482/packages/react-dom/src/__tests__/ReactDOMServerIntegrationElements-test.js#L391

https://github.com/facebook/react/blob/03de849af03996b7477420c97de7741ce1214149/packages/react-dom/src/__tests__/DOMPropertyOperations-test.js#L41

I'll go sleep

srghma changed the title ~~how to render and hydrate svg elements~~ how to render and hydrate namespaces elements and attributes

Author

srghma commented Aug 1, 2020 •

edited

Loading

I have found that people use namespaced attributes wrongly

I wonder if this really results in right Dom because it doesn't call setAttributeNs

https://github.com/kayhide/jigsole/blob/22b837d238c797eb7a6845274814a8435d155804/frontend/src/Ext/Svg/Attributes.purs#L10

https://github.com/input-output-hk/plutus/blob/046bf09bf41b97b7e8e14bf8859ce171ded035e6/marlowe-playground-client/src/Halogen/SVG.purs#L244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment