Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publication Year Range Facet Plugin "Run" button isn't labeled. #4692

Open
3 tasks
kevinreiss opened this issue Jan 10, 2025 · 1 comment · May be fixed by #4705
Open
3 tasks

Publication Year Range Facet Plugin "Run" button isn't labeled. #4692

kevinreiss opened this issue Jan 10, 2025 · 1 comment · May be fixed by #4705
Assignees
@christinach
Labels
bug sudden-priority

Comments

@kevinreiss
Copy link
Member

Expected behavior

When I use the Publication Range Year Facet date slider I can see a labeled "Run" or "Submit" button that will apply the date range I've selected to the results I am reviewing.

Actual behavior

The button to apply the range isn't labeled and is barely visible. See this screenshot.
Screenshot 2025-01-10 at 12 07 30 PM

Steps to replicate

  1. Got to catalog.princeton.edu
  2. Open the Publication Year Facet
  3. Try to find the "Run" option to the right of the date range slider.

Impact of this bug

Confusing using experiences. If you select the little bit of the run button the facet works.

Acceptance criteria

  • The "Run" button on the Publication Year Facet is visible.
  • I can successfully use this feature with Voice Over in Safari.
  • I have checked this feature using one of the following browser extensions and confirmed that it does not add any level A or level AA issues:
    • axe dev tools
    • Lighthouse
    • Wave
@rladdusaw
Copy link
Contributor

Could try upgrading to the new major version of the range-limit gem and see if it fixes the issue.

@christinach christinach self-assigned this Jan 15, 2025
@christinach christinach linked a pull request Jan 15, 2025 that will close this issue
Draft
christinach added a commit that referenced this issue Jan 22, 2025
@christinach
[#4692] render the componenet in the numismatics form
fa06570
christinach added a commit that referenced this issue Jan 23, 2025
@christinach @sandbergja
[#4692] Pass a valid display_facet in the pub_date_presenter method
352e325 
Co-authored-by: Jane Sandberg <[email protected]>
christinach added a commit that referenced this issue Jan 23, 2025
@christinach
[#4692] Create range_form_component to override the html and remove t…
8521585 
…he Apply submit button
christinach added a commit that referenced this issue Jan 23, 2025
@christinach
[#4692] Create range_form_component to override the html and remove t…
e8c95c2 
…he Apply submit button
christinach added a commit that referenced this issue Jan 23, 2025
@christinach
[#4692] render the componenet in the numismatics form
57d0a21
christinach added a commit that referenced this issue Jan 23, 2025
@christinach @sandbergja
[#4692] Pass a valid display_facet in the pub_date_presenter method
3986b7a 
Co-authored-by: Jane Sandberg <[email protected]>
christinach added a commit that referenced this issue Jan 23, 2025
@christinach
[#4692] Create range_form_component to override the html and remove t…
38c3fa9 
…he Apply submit button
christinach added a commit that referenced this issue Jan 23, 2025
@christinach
[#4692] Create range_form_component to override the html and remove t…
3dd9f7c 
…he Apply submit button
christinach added a commit that referenced this issue Jan 23, 2025
@christinach
[#4692] Update the publication facet spec to test the submit button
bb9696c
christinach added a commit that referenced this issue Jan 24, 2025
@christinach
[#4692] render the componenet in the numismatics form
793c0b5
christinach added a commit that referenced this issue Jan 24, 2025
@christinach @sandbergja
[#4692] Pass a valid display_facet in the pub_date_presenter method
a299fca 
Co-authored-by: Jane Sandberg <[email protected]>
christinach added a commit that referenced this issue Jan 24, 2025
@christinach
[#4692] Create range_form_component to override the html and remove t…
268082c 
…he Apply submit button
christinach added a commit that referenced this issue Jan 24, 2025
@christinach
[#4692] Update the publication facet spec to test the submit button
a5ef93a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christinach christinach

Labels
bug sudden-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade blacklight_range_limit to v9.0.0 pulibrary/orangelight
3 participants
@kevinreiss @christinach @rladdusaw