Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Hydra Editor #5262

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Remove Hydra Editor #5262

merged 2 commits into from
Jul 25, 2022

Conversation

tpendragon
Copy link
Contributor

@tpendragon tpendragon commented Jul 21, 2022 •
edited
Loading

Closes #5264

@tpendragon tpendragon force-pushed the remove_hydra_editor branch 2 times, most recently from 74a1fe8 to f44a381 Compare July 22, 2022 11:38
@tpendragon tpendragon force-pushed the remove_hydra_editor branch from f44a381 to 3f8a807 Compare July 23, 2022 20:16
hackartisan
hackartisan requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great my only question is whether we need some new tests.

Even just some feature tests, maybe, that check for the inputs and exercise the add / remove additional values buttons?

@tpendragon tpendragon requested a review from hackartisan July 25, 2022 20:41
eliotjordan
eliotjordan approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@eliotjordan eliotjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eliotjordan eliotjordan merged commit 1644fd0 into rails-6-again Jul 25, 2022
@eliotjordan eliotjordan deleted the remove_hydra_editor branch July 25, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliotjordan eliotjordan eliotjordan approved these changes

@hackartisan hackartisan hackartisan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpendragon @eliotjordan @hackartisan