Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: delete reqwest as dependency #301

Open
tipogi opened this issue Jan 24, 2025 · 0 comments
Open

Deps: delete reqwest as dependency #301

tipogi opened this issue Jan 24, 2025 · 0 comments
Assignees
Labels
dependencies Pull requests that update a dependency file refactor Non-Feature Update

Comments

@tipogi
Copy link
Collaborator

tipogi commented Jan 24, 2025

The only usage of this dependency in the src folder is here. We should consider refactoring to remove it from production code and move it to dev-dependencies instead, reducing unnecessary dependencies in the final build.

Another option would be to use the url crate, which is a lightweight alternative. Additionally, reqwest::Url is just a re-export of url::Url, so using url::Url directly avoids pulling in reqwest as a dependency.

@tipogi tipogi added the refactor Non-Feature Update label Jan 24, 2025
@tipogi tipogi self-assigned this Jan 24, 2025
@SHAcollision SHAcollision changed the title Delete reqwest dependency Deps: delete reqwest as dependency Jan 26, 2025
@SHAcollision SHAcollision added the dependencies Pull requests that update a dependency file label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file refactor Non-Feature Update
Projects
None yet
Development

No branches or pull requests

2 participants