Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPRIS Tune Publishing does not function #799

Open
Slips-PC opened this issue May 9, 2022 · 16 comments
Open

MPRIS Tune Publishing does not function #799

Slips-PC opened this issue May 9, 2022 · 16 comments
Assignees
Labels

Comments

@Slips-PC
Copy link

Slips-PC commented May 9, 2022

Hi, I'm using psi-plus-git (as packaged on the AUR) and I cannot seem to get tune publishing to work. The button in the top right cannot be pressed, I have my PEP configuration as follows:
image
I am using the Clementine music player, I know this music player supports MPRIS and I know it works with tune publishing, as Gajim has no issues publishing from it. I am unsure of what is wrong.

@Ri0n Ri0n added the Bug label May 9, 2022
@Ri0n
Copy link
Member

Ri0n commented May 9, 2022

I just tested with Clementine 1.4.0 and Psi 1.5.1618 on Ubuntu 22.04. It works well. Tested with Icecast internet radio and default settings for tune controller with just enabled "publish tunes".

so the problem needs further investigation. maybe MPRIS protocol changed or something like this. Or maybe Arch version was compiled w/o dbus support.

@Vitozz can you check on your Arch?

@tehnick
Copy link
Member

tehnick commented May 9, 2022

I do not see anything about D-Bus in PKGBUILD:
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=psi-plus-git
And USE_DBUS option is enabled by default in cmake.

@tehnick
Copy link
Member

tehnick commented May 9, 2022

PKGBUILD for clementine does not have any notes about dbus either:
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=clementine-git
And it should be enabled if Qt5DBus library is found in the system:
https://github.com/clementine-player/Clementine/blob/master/CMakeLists.txt

@Vitozz
Copy link
Member

Vitozz commented May 9, 2022

Just tested mpris and clementine on my manjaro. Everything works well.
https://i.imgur.com/pFbzLJS.png

@Vitozz
Copy link
Member

Vitozz commented May 9, 2022

By the way, it depends on DE. Dbus service should be enabled and started.

@Slips-PC
Copy link
Author

Slips-PC commented May 9, 2022

dbus is running on my machine as i've confirmed (see below pic), and tune publishing works on Gajim through the same methods.

Of note is that the toggle tune publishing button does not function. It remains pressed constantly and clicking on it does nothing. Unsure if this is intended behavior or otherwise.
image

@Ri0n
Copy link
Member

Ri0n commented May 9, 2022

Of note is that the toggle tune publishing button does not function.

That's curious. maybe something wrong with the xmpp part. What server do you use?

@Slips-PC
Copy link
Author

Slips-PC commented May 9, 2022

What server do you use?

I use my own personal server. Running Prosody 0.12.0, which supports XEP-0118 (Tune Publishing) natively. Tune Publishing works on the server when using Gajim, so I think that can be ruled out.

@Ri0n
Copy link
Member

Ri0n commented May 9, 2022

I'll check later with your version of server. But at least it works with Prosody 0.11.12.
Problems with the button may mean there is something wrong with the feature discovery.
If MPRIS xep was updated for example then maybe we need to fix something in Psi to support new standards.

@Slips-PC
Copy link
Author

Slips-PC commented May 9, 2022

I'm currently compiling a fresh version in a vm to see if this issue occurs between machines or is relegated to mine only. Will report back.

@Slips-PC
Copy link
Author

Slips-PC commented May 9, 2022

Just compiled a fresh version in a VM, same issue. Must be some sort of incompatibility between Prosody 0.12's implementation of MPRIS tune publishing and psi-plus?

EDIT: I did some asking around on the Prosody XMPP channels and I found this link documenting a bunch of changes to PEP and pubsub between 0.11 and 0.12. Now, I couldn't read lua if it was staring me dead in the face, but perhaps one of you folks might be able to find something important in here?

@Vitozz
Copy link
Member

Vitozz commented May 9, 2022

The implementation of mpris in psi fully complies with the freedesktop specification. Psi supports both protocol versions 1 and 2. Psi, when the mpris controller is on, reacts to the addition of new interfaces to the dbus. If the interface matches any version of the protocol - psi listens to events from the interface and publishes a tune based on metadata (version 2) or tags (version 1).
You can use Psi File controller to check your prosody server, Just create a file named "tune" in ~/.cache/psi (~/.cache/psi+ for Psi+) with some content.

@tehnick
Copy link
Member

tehnick commented May 9, 2022

@Slips-PC Could you join to [email protected] chat?

@Slips-PC
Copy link
Author

Slips-PC commented May 9, 2022

@Slips-PC Could you join to [email protected] chat?

I am about to go AFK for a bit but when I get back, yes.

@Neustradamus
Copy link

@Slips-PC: Your problem has been solved?

Please look with latest build.

@Vitozz
Copy link
Member

Vitozz commented Sep 5, 2024

Probably we could close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants