Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of find_volume to XDG #45

Open
pshriwise opened this issue Jan 24, 2025 · 0 comments
Open

Addition of find_volume to XDG #45

pshriwise opened this issue Jan 24, 2025 · 0 comments
Assignees

Comments

@pshriwise
Copy link
Owner

pshriwise commented Jan 24, 2025

DAGMC and double-down both have an option to find what volume a location is in without looping over all volume trees.

First we should address issue #4 in XDG so that triangle references/surface geometries aren't duplicated. Part of that process will also provide us with the surface sense information on each surface so we can reference it during the find_volume operation.

Once that's complete, then we can look at joining all of the geometries into a single BVH to perform a find_volume operations and avoid a loop over all of the volume trees in the model.

Single BVH creation in double-down: https://github.com/pshriwise/double-down/blob/f85a1ac4e1f450414be2513c3b123d88db2c81d6/src/RTI.cpp#L720-L721
Find volume implementation in double-down: https://github.com/pshriwise/double-down/blob/f85a1ac4e1f450414be2513c3b123d88db2c81d6/src/RTI.cpp#L312

@pshriwise pshriwise converted this from a draft issue Jan 24, 2025
@pshriwise pshriwise assigned pshriwise and Waqar-ukaea and unassigned pshriwise Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants