Skip to content
This repository has been archived by the owner on Jun 27, 2024. It is now read-only.

Reset button not working when used in slots #97

Open
jdsantos opened this issue Oct 21, 2022 · 3 comments
Open

Reset button not working when used in slots #97

jdsantos opened this issue Oct 21, 2022 · 3 comments

Comments

@jdsantos
Copy link

jdsantos commented Oct 21, 2022

Hi there!

First of all, thank you for your contribution to the community with this package.
I'm using this package in a small project, and at some point i needed to customize the TableReset slot which i did with the following:

<Table>
<template #tableReset="resetProps">
</template>
</Table>

The resetProps (unspreaded) has the onClick property well defined, and canBeReset property always with the value of "canBeReset". I do think it is always like this because of a small binding error here:
https://github.com/jdsantos/inertiajs-tables-laravel-query-builder/blob/main/js/Components/Table.vue#L52

I will make a PR and if you think this solves the problem correctly please merge it.

Thanks!

@jdsantos
Copy link
Author

here is the PR #98

@jdsantos jdsantos changed the title Reset button not working then used in slots Reset button not working when used in slots Oct 21, 2022
@jdsantos
Copy link
Author

jdsantos commented Nov 7, 2022

Any updates on this?

@jdsantos
Copy link
Author

Anyone?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant