Styling in tiles viewer may not work for multi geometries (if using maplibre-gl 5)

[prusswan]

I was using the tile viewer styling, only to realize that multi geometries were not showing up properly.

Turns out this was due to a breaking change in maplibre-gl v5:

- "filter": ["==", ["geometry-type"], "Polygon"]
+ "filter": ["==", "$type", "Polygon"]

[wipfli]

Hi @prusswan. If you are referring to the protomaps basemap, this was fixed in the protomaps basemaps style here: protomaps/basemaps#341

[prusswan]

Hi @prusswan. If you are referring to the protomaps basemap, this was fixed in the protomaps basemaps style here: protomaps/basemaps#341

Yeah, this is for the tooling at pmtiles.io (still using maplibre-gl v3), took me a while to realize why this is caused by v5.

[wipfli]

Ah OK but then I don't understand the issue. Can you share some reproduction steps?

[prusswan]

Ah OK but then I don't understand the issue. Can you share some reproduction steps?

It is not happening "yet", but when the version is upgraded:

PMTiles/app/package.json

Line 23 in 275b5bc

"maplibre-gl": "3.3.1",

[bdon]

We should only need to change these geometry-type checks to use $type:

https://github.com/protomaps/PMTiles/blob/main/app/src/MaplibreMap.tsx#L271