Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Extension - Inconsistent final modifier for Google\Protobuf\Timestamp #20037

Open
FabioBatSilva opened this issue Jan 18, 2025 · 0 comments
Labels
untriaged auto added to all issues by default when created.

Comments

@FabioBatSilva
Copy link

In PHP C extension implementation of Google\Protobuf\Timestamp is marked as final but not in the native PHP implementation.

This creates inconsistency between the two:

PHP Implementation :

class Timestamp extends \Google\Protobuf\Internal\TimestampBase

C Implementation

google_protobuf_Timestamp_ce->ce_flags |= ZEND_ACC_FINAL;

@FabioBatSilva FabioBatSilva added the untriaged auto added to all issues by default when created. label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged auto added to all issues by default when created.
Projects
None yet
Development

No branches or pull requests

1 participant