Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker images to Github Container Registry too #12616

Open
behroozbc opened this issue Jul 29, 2023 · 5 comments · May be fixed by prometheus/promci#26 or #15800
Open

add docker images to Github Container Registry too #12616

behroozbc opened this issue Jul 29, 2023 · 5 comments · May be fixed by prometheus/promci#26 or #15800

Comments

@behroozbc
Copy link

Proposal

Hi,
the Github Container Registry is a good tool that github add to its toolset.
Please add the prometheus images to the Github Container Registry too.

@krajorama
Copy link
Member

Hello from the bug scrub. This seems like a valid request. WDYT @SuperQ ?

@krajorama : I think this needs team member permissions to set up some PAT or application to be able to push to our https://github.com/orgs/prometheus/packages .

@SuperQ
Copy link
Member

SuperQ commented Jan 7, 2025

Seems reasonable to me. I don't have time to work on our tooling to do this.

@webysther
Copy link

webysther commented Jan 9, 2025

Looks like the work is here https://github.com/prometheus/prometheus/blob/main/.github/workflows/ci.yml#L219 but normally is used docker/login-action and is a bit custom, I have open some PR to use this, but in this case I have no ideia, sorry.

@webysther
Copy link

webysther commented Jan 9, 2025

@beorn7 is necessary to admin to create ghcr_io_organization, ghcr_io_login and ghcr_io_password and check the packages of the account. One important thing, public packages don't count, no costs.

I have create a PR just for the release, but this can be expanded to the main branch also.

@beorn7
Copy link
Member

beorn7 commented Jan 9, 2025

I guess we need an GH org owner for the permissions setup. I am not very familiar with our build pipeline, but maybe we can find a volunteer org owner to collaborate with @webysther to get things rolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants