Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] - Ability to add comment per line in an input file (e.g. for -eid or -etag) #5956

Closed
aviadavi opened this issue Jan 6, 2025 · 3 comments · Fixed by #5960
Closed

[FEATURE] - Ability to add comment per line in an input file (e.g. for -eid or -etag) #5956

aviadavi opened this issue Jan 6, 2025 · 3 comments · Fixed by #5960
Assignees
@dogancanbakir
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
Nuclei v3.3.9

Comments

@aviadavi
Copy link

aviadavi commented Jan 6, 2025

Describe your feature request

Ability to add comment per line , for example:

tls-sni-proxy # This is example 1
some-other-id # This is example 2
for -exclude-id

Describe the use case of the feature

We will be able to provide a comment next to the line saying why we put this line .. (reason)

Describe alternatives you've considered

Additional context

No response
@aviadavi aviadavi added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 6, 2025
@GeorginaReeder
Copy link

Thanks for your feature request @aviadavi , we'll take a look into this!

@dogancanbakir
Copy link
Member

dogancanbakir commented Jan 7, 2025 •
edited
Loading

@aviadavi, do you need this only for -eid and -etag? For example, we did it for the input only in subfinder projectdiscovery/subfinder#1346

@dogancanbakir dogancanbakir self-assigned this Jan 7, 2025
@aviadavi
Copy link
Author

aviadavi commented Jan 7, 2025

@aviadavi, do you need this only for -eid and -etag? For example, we did it for the input only in subfinder projectdiscovery/subfinder#1346

personally yes .. but whatever you think is best

thanks!

This was referenced Jan 7, 2025
Closed
Merged
@ehsandeep ehsandeep added this to the Nuclei v3.3.9 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dogancanbakir dogancanbakir

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
Nuclei v3.3.9
Development

Successfully merging a pull request may close this issue.

Allow comments in files projectdiscovery/nuclei
4 participants
@ehsandeep @aviadavi @dogancanbakir @GeorginaReeder