From ef7bd22491e3f2c462bd2b0c944010ed2c009a2d Mon Sep 17 00:00:00 2001 From: Jason LeBrun Date: Fri, 24 May 2024 17:43:03 +0000 Subject: [PATCH] Remove kokoro/format.sh script We've removed the corresponding kokoro job. This is a subset of check_format, with the --fix flags instead of --check flags. It doesn't make sense to run this as part of presubmit or CI. Bug: 341167730 Change-Id: I492c943bd81c366a19caefb9307ba13e66d19ad0 --- .github/workflows/ci.yaml | 3 --- kokoro/format.sh | 7 ------- 2 files changed, 10 deletions(-) delete mode 100755 kokoro/format.sh diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index c8a12739986..42dad65d8d9 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -22,9 +22,6 @@ jobs: matrix: # Do not add `run-ci` to these commands. We parse them for `xtask run-ci`. cmd: - # format tries to format all the source files, and relies on the git diff step to determine whether anything was missed. - - format - # check-format checks for additional issues (e.g. missing license headers) that format does not enforce. - check-format - run-cargo-deny - run-cargo-udeps diff --git a/kokoro/format.sh b/kokoro/format.sh deleted file mode 100755 index 3f973574a5d..00000000000 --- a/kokoro/format.sh +++ /dev/null @@ -1,7 +0,0 @@ -#!/usr/bin/env bash - -# shellcheck source=./kokoro/common.sh -source "$(dirname "$0")/common.sh" - -./scripts/docker_pull -./scripts/docker_run nix develop .#ci --command ./scripts/xtask format