Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button unblocks YouTube videos blocked by a keyword #339

Open
Anton-V-K opened this issue Dec 5, 2023 · 3 comments
Open

Back button unblocks YouTube videos blocked by a keyword #339

Anton-V-K opened this issue Dec 5, 2023 · 3 comments

Comments

@Anton-V-K
Copy link

Anton-V-K commented Dec 5, 2023

With default settings the rules to block pages by keyword are usually ignored when the Back button is pressed on the blocked page.

Scenario:

  1. Block by keyword (let it be ~roblox, don't forget about the first entry, which is *) + All Day.
  2. Go to a page where the keyword is present (let it be https://www.youtube.com/watch?v=-em-iNtwvH4 or you can find other videos via search) => the page is blocked (OK).
  3. Press the Back button => the page is unblocked (BUG), and if you open same video in other tab it won't be blocked.

Workaround: enable the option Immediately block pages on these sites once blocking conditions are met, which is . However now the blocking happens when you just type ro in google search, because the suggestions usually contain roblox.

Extension version 1.6
Browser: Supermium 119.0.6045.192 64-bit (should also happen in any modern Chromium-based browser, I use this browser because the extension doesn't work in the last supported version of Chromium - see #338)
OS: Windows 8.1 64-bit

@Anton-V-K
Copy link
Author

Oops, the initial issue belongs to https://github.com/proginosko/LeechBlockNG-chrome (I had wrong impression that the code was the same for all extensions %).
I can't verify whether the same issue is applicable for the Firefox extension, because it doesn't block by keywords at youtube at all (Firefox 119.0 32-bit / Windows 10 21H1 64-bit / extension's version 1.6).

@proginosko
Copy link
Owner

Are you saying blocking YouTube by keyword doesn't work on Firefox?

@Anton-V-K
Copy link
Author

I checked the behavior in other environment (Firefox 117.0.1 64-bit / Windows 21H1 64-bit / extension version 1.6), and blocking by keywords seems to work on YouTube, though the Back button cancels the blocking, so the original issue report is applicable to Firefox extension as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants