Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - LB Reports wrong Unblock time when site is listed in more than one block set #330

Open
smayer97 opened this issue Oct 2, 2023 · 1 comment

Comments

@smayer97
Copy link

smayer97 commented Oct 2, 2023

If a site is listed in 2 sets, LB seems to shows the unblock time from the first set it encounters, even when there are other criteria that makes the unblock time later.

Let's say it is 8AM. Criteria for block set 1 makes the unblock time 9AM but another block set makes the unblock time 3pm. LB, will report the unblock time as 9AM, instead of the correct applicable time of 3PM.

I see how LB might be processing the info from block sets. The problem is this presentation is inaccurate and misleading. As a user, they are lead to believe that the site will unblock at 9AM but when 9AM rolls around, LB then displays that the site will only unblock at 3pm.

Can this be corrected?

@proginosko
Copy link
Owner

I don't see this as a priority. The blocking page shows which block set triggered the block, and the unblock time shown applies to that block set. So it's not inaccurate per se. Since the user is the one who sets up the block sets, it shouldn't be a surprise to him/her if another block set kicks in later!

All this to say, it would require a fair bit of work to change this, and I would rather spend the time on more pressing issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants