Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovered a block bypass: a locked block can be disabled by moving a different block ahead of it #252

Open
iliadaili opened this issue Jul 6, 2022 · 2 comments

Comments

@iliadaili
Copy link

iliadaili commented Jul 6, 2022

Hi!

I discovered a workaround for locked blocks, that is, blocks with the ''prevent access to options for this block set at times when these sites are blocked'' option enabled. If I have, for example, a block for YouTube that gets locked when it's on, I can disable it by creating another block for youtube that puts a filter on the page instead of fully blocking it. So, instead of being unable to use YouTube, I can easily get access to it with grayscale or some other filter. This issue actually appeared with the implementation of a suggestion that I gave before, so I am sorry for this. I didn't foresee that it would create this problem.

I think maybe the problem could be resolved by temporarily prioritizing locked blocks when they are turned on, so every locked block would be prioritized above all others. Of course, you could still create a block with a filter and lock it. But then, when two locked blocks targetted the same site, the one that started before would take precedence, so you wouldn't be able to bypass the block middway the block period (which is the issue really, since the block can be edited freely when it's off).

I don't suppose this would be easy, considering keywords and every functionality that leechblock offers inside a block, but I hope it can be helpful.

Maybe, if that doesn't work, the prioritization between locked blocks could happen according to how strict a block is, so it would be something like: blocks that fully block website > blocks that take you to a delaying page of 2X seconds > blocks that take you to a delaying page of X seconds > muted filter blocks > unmuted filter blocks.

Thank you for reading.

@proginosko
Copy link
Owner

Thanks for posting the issue. I appreciate the suggestions, but I worry that prioritizing blocks according to a complicate algorithm will spell confusion for users. A simpler solution would be to disallow moving any block sets before any locked sets.

@HiddenMachine3

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants