Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init function in IMT trees can be called multiple times #42

Open
0xDatapunk opened this issue Oct 7, 2024 · 3 comments
Open

init function in IMT trees can be called multiple times #42

0xDatapunk opened this issue Oct 7, 2024 · 3 comments
Assignees
Labels
audit 🔍 This issue is related to an audit. bug 🐛 Something isn't working good first issue Good for newcomers

Comments

@0xDatapunk
Copy link

function init(QuinaryIMTData storage self, uint256 depth, uint256 zero) public {

function init(BinaryIMTData storage self, uint256 depth, uint256 zero) public {

function init(LazyIMTData storage self, uint8 depth) public {

Should we put in place a mechanism to always call init once and only once?

@cedoor cedoor added this to ZK-Kit Oct 14, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ZK-Kit Oct 14, 2024
@cedoor cedoor added bug 🐛 Something isn't working audit 🔍 This issue is related to an audit. labels Oct 14, 2024
@cedoor cedoor added the good first issue Good for newcomers label Oct 24, 2024
@cedoor
Copy link
Member

cedoor commented Oct 24, 2024

Yes, makes sense!

@eshumanohare
Copy link

hello @cedoor @0xDatapunk , can I take this issue if no-one is assigned to it yet?

@cedoor
Copy link
Member

cedoor commented Oct 28, 2024

Hi, @eshumanohare yes of course 👍🏽

@cedoor cedoor moved this from ♻️ Grooming to 🏗 In Progress in ZK-Kit Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit 🔍 This issue is related to an audit. bug 🐛 Something isn't working good first issue Good for newcomers
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

3 participants