Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review code to take into account the changes from MkDocs 1.4.0 #249

Open
prcr opened this issue May 23, 2023 · 2 comments
Open

Review code to take into account the changes from MkDocs 1.4.0 #249

prcr opened this issue May 23, 2023 · 2 comments

Comments

@prcr
Copy link
Owner

prcr commented May 23, 2023

Go through the breaking changes from the MkDocs 1.4.0 changelog and make any necessary changes to the code to ensure that it is compatible with MkDocs 1.4.0.

Supersedes #193.

@codeautopilot
Copy link

codeautopilot bot commented May 23, 2023

Based on the file-level summary, it appears that no changes are needed in the project's setup.py and plugin.py files to ensure compatibility with MkDocs 1.4.0. Therefore, you can continue to use these files as is without any modifications.

Changes on setup.py

No changes are needed in this file to ensure compatibility with MkDocs 1.4.0.

Changes on mkdocs_meta_descriptions_plugin/plugin.py

No changes are needed in this file based on the MkDocs 1.4.0 changelog.

@prcr
Copy link
Owner Author

prcr commented May 23, 2023

Consider applying the following:

  • Replace File.src_path to not deal with backslashes
  • Type annotations for event handler methods
  • Rework ConfigOption schemas as class-based

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant