Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for read-only mode (mirrored request) #12

Closed
mizvyt opened this issue Oct 25, 2019 · 5 comments
Closed

Add support for read-only mode (mirrored request) #12

mizvyt opened this issue Oct 25, 2019 · 5 comments
Milestone
0.5.0

Comments

@mizvyt
Copy link
Contributor

mizvyt commented Oct 25, 2019 •
edited
Loading

This original comes from here:
axiak/pybloomfiltermmap#59

Also added here:
axiak/pybloomfiltermmap#83

Since the original repository seems to be dead, it would be nice to see some updates here.
@mizvyt
Copy link
Contributor Author

mizvyt commented Nov 21, 2019 •
edited
Loading

Addressed in #13

@prashnts
Copy link
Owner

prashnts commented Nov 21, 2019 •
edited
Loading

Thanks! I've reviewed them and after you've seen them we can prepare a release.

Since this is not really a bugfix patch, let's bump next release to v0.5.0?

@mizvyt
Copy link
Contributor Author

mizvyt commented Nov 22, 2019

Since this is not really a bugfix patch, let's bump next release to v0.5.0?

Sounds good! We could add a milestone and include the pending PRs with this tag.

@prashnts
Copy link
Owner

Great, would you mind resolving merge conflict in #13? I'll upload the package to pypi by evening tomorrow.

In summary: v0.5.0 would include #11, #13 and #14. Nice! :D

@prashnts prashnts added this to the next milestone Nov 23, 2019
@prashnts
Copy link
Owner

Closed via b903066

v0.5.0 is up on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@prashnts @mizvyt