Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

footgun: configuring IdP, not setting authenticate #873

Open
wasaga opened this issue Jan 12, 2024 · 0 comments
Open

footgun: configuring IdP, not setting authenticate #873

wasaga opened this issue Jan 12, 2024 · 0 comments
Labels
nit

Comments

@wasaga
Copy link
Collaborator

wasaga commented Jan 12, 2024

What happened?

we made authenticate options of the CRD optional when hosted authenticate was introduced, it is now possible to set identityProvider portion of the CRD without filling in authenticate portion.

This configuration would be applied, as CRD rules cannot prevent it now, although it's fundamentally incorrect, and will cause some side effects.

What did you expect to happen?

Such configuration should be rejected, and an error set to the CRD /status section.
@wasaga wasaga added the nit label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wasaga