Setup system parachain runtimes benchmarking for delivering to sibling parachains instead of Parent

[bkontur]

Description

Currently, all system parachains benchmarking setups for pallet_xcm::benchmarking::Config or pallet_xcm_benchmarks::Config are written to deliver to the Parent (i.e., the relay chain), such as for all asset transfers.

As we are transitioning functionality, like balances, from the relay chain to the asset hubs, we need to update these benchmarks to reflect this migration.

Relevant Changes

Delivery Helpers:
Replace DeliveryHelpers that use cumulus_primitives_utility::ToParentDeliveryHelper (example) with polkadot_runtime_common::xcm_sender::ToParachainDeliveryHelper (example).

Destination Updates:
Review and update all destinations used in the benchmarks, including:

• fn valid_destination()
• fn subscribe_origin()
• fn set_up_complex_asset_transfer()
• TrustedTeleporter
• ...

This ensures the benchmarks are aligned with the changes in architecture and accurately reflect the new delivery paths.

TODO/Progress

• revisit/fix all system parachain benchmark setup for pallet_xcm::benchmarking::Config
• revisit/fix all system parachain benchmark setup for pallet_xcm_benchmarks::Config
• check all other non-xcm benchmarks
• investigate coretime (uses calls to Parent) ?

[Nathy-bajo]

@bkontur I want to try attempting this!

[bkontur]

@bkontur I want to try attempting this!

Actually, there’s an equivalent issue for testnets, which I would prefer to have completed first. This allows us to catch, test, and refine things there. Later, we can simply replicate the relevant changes to the Fellows runtimes.

However, that issue is already claimed. That said, you’re more than welcome to participate in paritytech/polkadot-sdk#7211, at least as a reviewer.