Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label for Set as First to Compare not show for cloned tab in second view #234

Open
ArkadiuszMichalski opened this issue Apr 24, 2020 · 2 comments

Comments

@ArkadiuszMichalski
Copy link

ArkadiuszMichalski commented Apr 24, 2020

Hi, I see that label for Set as First to Compare command not show for cloned tab in second view, although this function works correct for other compares/clears commands. Step to reproduce:

1. Open File1 and File2 in first view.
2. Clone File2 to second view.
3. Select File2 on second view and invoke `Set as First to Compare`. << at this moment we don't see `New to Compare` label on this tab but looks like other things works correct (for example clear icon has blue color).
4. Select File1 in first view and invoke `Compare` command.

After all we still get the result of the comparison, so missing this label is really small bug. It is worth adding that in the first view this label always appear for cloned tab, problem exist only for cloned tab in second view.

@ArkadiuszMichalski ArkadiuszMichalski changed the title Label for Set as First to Compare not show for clonded tab in second views Label for Set as First to Compare not show for cloned tab in second views Apr 24, 2020
@ArkadiuszMichalski ArkadiuszMichalski changed the title Label for Set as First to Compare not show for cloned tab in second views Label for Set as First to Compare not show for cloned tab in second view Apr 24, 2020
@pnedev
Copy link
Owner

pnedev commented Apr 25, 2020

Hi @ArkadiuszMichalski ,

I'll check that as well, thank you for the detailed description.

BR

@pnedev pnedev added the bug label Apr 25, 2020
@pnedev pnedev added this to the ComparePlus v1 milestone Nov 22, 2020
@pnedev pnedev removed the on hold label May 19, 2022
@pnedev
Copy link
Owner

pnedev commented Jul 19, 2022

Hello @ArkadiuszMichalski ,

Sorry for writing after such a long time.
This is a minor issue that is not easily fixable so I'll keep it as it is.

Thanks for reporting that and for the patience.
BR

@pnedev pnedev removed this from the ComparePlus v1 milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants