-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add page for community components #3378
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3889166:
|
Replace images with the same props as CodeSandBox component: `className="aspect-[16/9] object-cover" width="1763" height="926"` ```jsx [<Img src="image_url" alt="altName" className="aspect-[16/9] object-cover" width="1763" height="926" />](link_url) ```
as discussed on X, maybe a bit redundant with Discord's Showcase channel i think |
or we could write a
I'm for 2. |
Thanks for the feedback on X and here! Here is my take regarding the points you mentioned: I've been a long-time user of r3f/drei, but never saw a community collection of projects that did gather large threejs projects that expose react/r3f components. I'm thinking about large-scale projects rather than small set of utility reusable components, like other kind of renderers - 3d-tiles renderers from gkjohnson or nytimes r&d, luma labs gaussian splat renderer, looking glass etc. It would make sense to integrate it within the r3f doc for both discoverability - for those not on discord, or who rely a lot on exploring doc + github - and showcase, which could also in turn facilitate other teams/devs to add value to the fiber ecosystem. Regarding maintenance/curation of the selection of projects to add to this page, this should probably be at the discretion of the pmndrs team which hosts the doc page, with community contributions for adding new projects or removing outdated ones suggested via PRs the same way anyone could contribute more codesandboxes examples to the example docs page. I'm in favor of dissociating pages for
Looking forward to hearing your thoughts! |
Hi there, is there any feedback from others - either from the pmndrs team or outside - regarding this PR? I've integrated the feedback from @abernier to merge the Looking forward to hearing your feedback! |
Coming back on this after the new year, I think it made more sense to explode the existing, doc Any thoughts on this from the pmndrs team? |
This got missed. @drcmda, what do you think of this addition? I know you had full authorship of examples prior. |
Current version of the page is accessible here - just added the incredible takram clouds and atmosphere repos if you want a quick look. Don't hesitate if you need any edits. Note I stumbled on the Therefore I tried forking some codesandboxes to edit the thumbnail/screenshot, but did not successfully do it atm. Once this gets merged we can probably update these csb-ids with the original ones from the corresponding repos docs. |
See fix here pmndrs/docs#375 Fixed the fact that the ordering of props destructuring prevented applying custom screenshot_url to CSBs
Hi again, just did the final touch-ups following the merge of my fix for pmndrs/docs, so I could add original CodeSandboxes from the official repos of each project, with a user-controlled screenshot-urls for those that were missing. Everything is good to go from my point-of-view! |
Following the issue #3377 I opened earlier today, here is a PR that adds a page to the
Getting Started
section listing external/community r3f components that have not been merged to drei or part of the pmndrs github org. Preview is here!I've added all the components I know of, feel free to add more before merging!
Not docs does not seem to take the
screenshot_url
param visible here of the<Codesandbox />
component.