From ccfc1899b859d45814ea3592e20ebec4cb731c84 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Mon, 4 Mar 2024 15:04:17 +0000 Subject: [PATCH] Revert "BinaryStream: add PHPStan type hint for get() parameter" This reverts commit 22ac3f1d52ea128d12e5d92ccb46e1189d73e1ea. This doc comment turned out to be very inconvenient and would require propagating signed/unsigned types everywhere. Considering we're in the process of phasing out this library anyway, it doesn't make much sense to introduce this inconvenience everywhere. --- src/BinaryStream.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/BinaryStream.php b/src/BinaryStream.php index 86b289b..aedb25c 100644 --- a/src/BinaryStream.php +++ b/src/BinaryStream.php @@ -63,8 +63,6 @@ public function getBuffer() : string{ /** * @phpstan-impure * @throws BinaryDataException if there are not enough bytes left in the buffer - * - * @phpstan-param int<0, max> $len */ public function get(int $len) : string{ if($len === 0){