Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(Core): add check for openssl php package #74

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Feat(Core): add check for openssl php package #74

merged 4 commits into from
Jan 27, 2025

Conversation

stonebuzz
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

Prevent error when openssl php package is not installed (only suggest from GLPI with system:check_requirements)

[2025-01-24 14:56:25] glpiphplog.WARNING: *** PHP User Warning (512): Error during authorization code fetching: Call to undefined function TheNetworg\OAuth2\Client\Provider\openssl_x509_read() in /volume1/glpi/marketplace/oauthimap/inc/authorization.class.php at line 423
Backtrace :
...place/oauthimap/inc/authorization.class.php:423 trigger_error()
...e/oauthimap/front/authorization.callback.php:77 PluginOauthimapAuthorization->createFromCode()

Screenshots (if appropriate):

@stonebuzz stonebuzz added the bug Something isn't working label Jan 24, 2025
@stonebuzz stonebuzz self-assigned this Jan 24, 2025
trasher
trasher approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeems OK, but lint is not happy

@cedric-anne cedric-anne merged commit b1bfff4 into main Jan 27, 2025
3 checks passed
@cedric-anne cedric-anne deleted the check_for_openssl branch January 27, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-anne cedric-anne cedric-anne approved these changes

@trasher trasher trasher approved these changes

@Rom1-B Rom1-B Awaiting requested review from Rom1-B

Assignees

@stonebuzz stonebuzz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to "Create an authorization"
3 participants
@stonebuzz @trasher @cedric-anne