You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think we should rely on the internal implementation of Manager like this; the current docs for that Network.HTTP.Client.Internal state
No API stability is guaranteed for this module
which is generally the case for modules marked as internal.
We could probably just use a middleware to achieve the same thing. Or, if that's not possible, this code should document why it's necessary to use internal modules from another library
The text was updated successfully, but these errors were encountered:
mkVCClientEnv
ininferno-vc
currently uses the internals ofManager
(fromhttp-client
) to modify request headers and body:inferno/inferno-vc/src/Inferno/VersionControl/Client.hs
Lines 19 to 43 in f229ad9
I don't think we should rely on the internal implementation of
Manager
like this; the current docs for thatNetwork.HTTP.Client.Internal
statewhich is generally the case for modules marked as internal.
We could probably just use a middleware to achieve the same thing. Or, if that's not possible, this code should document why it's necessary to use internal modules from another library
The text was updated successfully, but these errors were encountered: