From 1eb7debf6bad9fe3c2d974ac7b396ba47d0d4674 Mon Sep 17 00:00:00 2001 From: archmoj Date: Fri, 21 Aug 2020 07:53:52 -0400 Subject: [PATCH 1/2] bump regl-scatter2d and fix issue 3246 maintain gl2d marker sizes with different pixel ratios --- package-lock.json | 6 +++--- package.json | 2 +- src/traces/scattergl/plot.js | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index ccf20a96d7e..11b12e26841 100644 --- a/package-lock.json +++ b/package-lock.json @@ -8863,9 +8863,9 @@ } }, "regl-scatter2d": { - "version": "3.1.9", - "resolved": "https://registry.npmjs.org/regl-scatter2d/-/regl-scatter2d-3.1.9.tgz", - "integrity": "sha512-tlNUxnwZB4PnTNDroRP6/RSBlfQ4Iha93vw+08sotk82ZEjBe0F13D+Bpm73awZHekn34mmlxA66r4bvi6Mvew==", + "version": "3.2.0", + "resolved": "https://registry.npmjs.org/regl-scatter2d/-/regl-scatter2d-3.2.0.tgz", + "integrity": "sha512-c0MxiakVW50UBslsHRmnq41w53bhat5oGvugZEpIZGTdKHVeopRAR2FQHeJf8YrEhOsVn7TpOk9tjySoyHXWGA==", "requires": { "@plotly/point-cluster": "^3.1.9", "array-range": "^1.0.1", diff --git a/package.json b/package.json index 75f3bc03a8a..5a27e1e314a 100644 --- a/package.json +++ b/package.json @@ -108,7 +108,7 @@ "regl": "^1.6.1", "regl-error2d": "^2.0.11", "regl-line2d": "^3.0.18", - "regl-scatter2d": "3.1.9", + "regl-scatter2d": "3.2.0", "regl-splom": "^1.0.12", "right-now": "^1.0.0", "robust-orientation": "^1.1.3", diff --git a/src/traces/scattergl/plot.js b/src/traces/scattergl/plot.js index a7d3c074f2e..abc58a2314c 100644 --- a/src/traces/scattergl/plot.js +++ b/src/traces/scattergl/plot.js @@ -67,7 +67,7 @@ module.exports = function plot(gd, subplot, cdata) { scene.line2d = createLine(regl); } if(scene.scatter2d === true) { - scene.scatter2d = createScatter(regl); + scene.scatter2d = createScatter(regl, { constPointSize: true }); } if(scene.fill2d === true) { scene.fill2d = createLine(regl); From e8499124cc11bf667832db668859df1b1401de08 Mon Sep 17 00:00:00 2001 From: archmoj Date: Fri, 21 Aug 2020 10:17:17 -0400 Subject: [PATCH 2/2] change mock to lock issue 3246 --- test/image/mocks/gl2d_marker_size.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/image/mocks/gl2d_marker_size.json b/test/image/mocks/gl2d_marker_size.json index cfd66112331..5abb624c2b1 100644 --- a/test/image/mocks/gl2d_marker_size.json +++ b/test/image/mocks/gl2d_marker_size.json @@ -71,5 +71,8 @@ "height": 400, "width": 480, "showlegend": false + }, + "config": { + "plotGlPixelRatio": 4 } }