Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config option plotGlPixelRatio changes size of markers #3246

Closed
antoinerg opened this issue Nov 15, 2018 · 9 comments · Fixed by #5093
Closed

config option plotGlPixelRatio changes size of markers #3246

antoinerg opened this issue Nov 15, 2018 · 9 comments · Fixed by #5093
Assignees
Labels
bug something broken

Comments

@antoinerg
Copy link
Contributor

antoinerg commented Nov 15, 2018

As @alexcjohnson found out while reviewing PR #3237, config option plotGlPixelRatio changes size of markers.

This is shown in this Codepen

@antoinerg antoinerg added the bug something broken label Nov 15, 2018
@antoinerg
Copy link
Contributor Author

For whoever who's going to fix this: the offending line in regl-scatter2d is there : https://github.com/gl-vis/regl-scatter2d/blob/8e68ee211dd7e8c2892e55eb392271994046cd00/marker-vert.glsl#L50

@alexcjohnson
Copy link
Collaborator

Are we actually using the pixel ratio? I can't detect any difference in antialiasing, in 2D or 3D, which is what I thought this was supposed to accomplish. The only change I notice is this bug.

One other thing to note: if I move a 3D from my second screen (window.devicePixelRatio = 1) to my laptop screen (window.devicePixelRatio = 2) it looks blurry until I newPlot - rotating the scene or even edits like turning traces on and off do not cause it to pick up the new screen resolution. But it looks beautiful after a newPlot.

2D plots never seem to use the increased resolution of my laptop screen, they're blurry even if that's where they were plotted in the first place.

So I'd say we have a number of things to sort out with config.plotGlPixelRatio!

@antoinerg
Copy link
Contributor Author

I am actually not sure we're using the pixel ratio. Maybe @archmoj would know!

@archmoj archmoj self-assigned this Nov 15, 2018
@archmoj
Copy link
Contributor

archmoj commented Feb 25, 2019

Next we could address this in a similar way done in #3573.

@whaatt
Copy link

whaatt commented May 26, 2020

Hi there! I followed this question regarding blurry rendering on high DPI (Retina) displays and arrived at this issue.

I was just wondering if the root cause of the issue is known or if the problem is being actively worked on.

If not, are there any hacky suggestions to force crisper rendering in the meantime? I looked into rendering the graph at 2X size and using CSS transforms to scale it down, but interactivity does not work well with scale().

Thanks in advance!

@agusterodin
Copy link

Hi there! I followed this question regarding blurry rendering on high DPI (Retina) displays and arrived at this issue.

I was just wondering if the root cause of the issue is known or if the problem is being actively worked on.

If not, are there any hacky suggestions to force crisper rendering in the meantime? I looked into rendering the graph at 2X size and using CSS transforms to scale it down, but interactivity does not work well with scale().

Thanks in advance!

Same here. Very surprised that plotly doesn't support hi dpi displays especially given how popular they are

@jbullock35
Copy link

Hi there! I followed this question regarding blurry rendering on high DPI (Retina) displays and arrived at this issue.

Same here. Very surprised that plotly doesn't support hi dpi displays especially given how popular they are

It's not just a problem on high-DPI displays. For example, see https://stackoverflow.com/questions/62498783/plotly-webgl-plots-are-fuzzy-blurry.

@nicolaskruchten
Copy link
Contributor

Cool! This will address https://community.plotly.com/t/webgl-plots-are-blurry/41716 right?

@archmoj
Copy link
Contributor

archmoj commented Aug 21, 2020

Cool! This will address https://community.plotly.com/t/webgl-plots-are-blurry/41716 right?

Possibly related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
7 participants