-
-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLIP: New feature hide and show Volto blocks #6559
Comments
The feature is valuable, and something clients asked us to do. So far, we refused to implement this feature because we see too many UX issues that have no obvious solution. The main problem, IMHO, is that the edit and the view view start to differ, which can confuse editors. To gain more experience with this, I'd recommend adding this feature with a feature flag first and gaining some experience and feedback before we enable it. This is usually our default approach when we change the Volto user interface. |
I agree with Timo's point of view, let's discuss it more in depth in the Volto Team meeting and let the PLIP goes through the process. |
PLIP (Plone Improvement Proposal)
Responsible Persons
Proposer: Sara Bianchi @SaraBianchi
Seconder: Giulia Ghisini @giuliaghisini
Abstract
New feature to hide or show blocks in view from the editor editing mode.
Motivation
Some customers have expressed the need to set up temporary blocks that will be activated or deactivated as needed.
A real use case could be to set up a block with a link to a YouTube live video that will be activated only when there is a session/conference.
Assumptions
Proposal & Implementation
In the Volto EditBlockWrapper, a button with an icon (eye/crossed-out eye) has been added to the center and top of the wrapper to hide or show a certain block. In addition to this, a button has also been added to the left side toolbar (above the Undo/Redo buttons) to switch to "Show hidden blocks too" mode or to collapse them to make the page preview functional.
More wrap layout details on the pull request.
Deliverables
The feature was requested in Volto version 17, but if it works we may open a pr for Volto main as well. Other packages were not affected.
This feature is quite urgent.
Risks
As explained in the pr, there is a risk of getting stuck inside collapsed blocks if you press the DEL button while moving from the keyboard, possible improvements can be managed in Slate type blocks, where it will be necessary to specify that if there are previously hidden blocks they must be bypassed.
Participants
Piero Nicolli @pnicolli participated in the review and exposition of the functionality already proposed in the past by me (@SaraBianchi).
Pull Request
Old closed pr: #5157
Open pr: #6556
The text was updated successfully, but these errors were encountered: