From 87bd1226681f18faa2df28e6a897f64b4a53fda2 Mon Sep 17 00:00:00 2001
From: Maurits van Rees <maurits@vanrees.org>
Date: Thu, 6 Jun 2024 23:32:52 +0200
Subject: [PATCH] No longer check visible_ids on the 'select default page'
 form.

Usage of ``visible_ids`` was largely removed in Plone 5.0 already, and you cannot change the setting on the portal or the member.
This was using the deprecated ``portal_properties`` tool.
See also https://github.com/plone/plone.app.contenttypes/pull/693
---
 news/125.bugfix                                            | 4 ++++
 plone/app/content/browser/templates/select_default_page.pt | 6 +-----
 2 files changed, 5 insertions(+), 5 deletions(-)
 create mode 100644 news/125.bugfix

diff --git a/news/125.bugfix b/news/125.bugfix
new file mode 100644
index 00000000..07313dda
--- /dev/null
+++ b/news/125.bugfix
@@ -0,0 +1,4 @@
+No longer check ``visible_ids`` on the 'select default page' form.
+Usage of ``visible_ids`` was largely removed in Plone 5.0 already, and you cannot change the setting on the portal or the member.
+This was using the deprecated ``portal_properties`` tool.
+[maurits]
diff --git a/plone/app/content/browser/templates/select_default_page.pt b/plone/app/content/browser/templates/select_default_page.pt
index 302fbd13..d7b33794 100644
--- a/plone/app/content/browser/templates/select_default_page.pt
+++ b/plone/app/content/browser/templates/select_default_page.pt
@@ -46,9 +46,6 @@
                      ">
             <tal:hasitems define="
                             n_items python:len(items);
-                            member portal_state/member;
-                            portal_visible_ids context/portal_properties/site_properties/visible_ids|nothing;
-                            member_visible_ids python:member.getProperty('visible_ids', context.portal_memberdata.getProperty('visible_ids'));
                           "
                           condition="items"
             >
@@ -56,7 +53,6 @@
                 <tal:item repeat="item items">
                   <dt tal:define="
                         normalized_type python:plone_view.normalizeString(item.portal_type);
-                        item_id python:'(%s)' % item.getId if (portal_visible_ids and member_visible_ids) else '';
                       ">
                     <input name="objectId"
                            type="radio"
@@ -67,7 +63,7 @@
                              checked python: (n_items==1 or item.getId==cur_page) and 'checked' or None;
                            "
                     />
-                    <label tal:content="string:${item/pretty_title_or_id} $item_id"
+                    <label tal:content="string:${item/pretty_title_or_id}"
                            tal:attributes="
                              for item/getId;
                              class string:contenttype-${normalized_type};