Fixed a crash on a malformed delete event #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplorentz
requested review from
joshuatbrown,
pelumy and
bryanmontz
as code owners
bryanmontz
reviewed
Jan 29, 2025
| let pubkey = components[1] | ||
|
|
||
| guard pubkey == author.hexadecimalPublicKey else { | ||
| guard let pubkey = components[safe: 1], |
There was a problem hiding this comment.
Yep, my fault. All direct array access should be done safely like this. Thanks!
bryanmontz
approved these changes
Jan 29, 2025
|
Why / how can a delete event be malformed? |
Because nostr is an open, permissionless protocol, any implementer of any app could send incorrectly formatted information, such as tags that don't actually follow the nostr spec. Therefore we have to code very defensively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#170
Description
A quick crash fix for something I came across while working on another ticket.
How to test
Run the unit tests. If you'd like you can revert the changes in
Event+CoreDataClass.swiftand verify that the test crashes.