Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added view for managing users in a list #135 #1738

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

bryanmontz
Copy link
Contributor

@bryanmontz bryanmontz commented Jan 21, 2025

Issues covered

https://github.com/verse-pbc/issues/issues/135

Description

Adds the view for managing which users are in a list.

How to test

Existing List:

  1. Navigate to Your Lists
    A. From the side menu
    B. From the feed picker dropdown, then Manage Your Lists.
  2. Tap on any list.
  3. Tap the ellipsis button at the top right.
  4. Tap Manage Users.
    Here you'll be presented with a search view with an empty search bar. The contents of the view below will be the existing users in the list. Typing in the search bar will bring up search results. The circular icon over the avatar indicates whether or not that user is currently in the list. Users can be added and removed here, and tapping Done will save the list.

Creating a new list:

  1. Navigate to Your Lists (see above)
  2. Tap the New button at the top right.
  3. Type in a name and optional description, and tap the Next button at the top right.
  4. Tap the Save button.
    The list is created and added to Your Lists.

Screenshots/Video

Editing an existing list: Here you'll see me view the detail screen for a list, then Manage Users, where I remove a user, add a user, and save.
edit-existing

Creating a new list: Here you'll see me create a new list with a title and description, then add a couple users to the list, then save it. Then I navigate to the feed and select the new list, where you can see there are only notes from the two users I added to the list.
create-new

@bryanmontz bryanmontz self-assigned this Jan 21, 2025
@bryanmontz bryanmontz changed the title added view for managing users in a list $135 added view for managing users in a list #135 Jan 21, 2025
@bryanmontz bryanmontz marked this pull request as draft January 21, 2025 14:32
@bryanmontz bryanmontz marked this pull request as ready for review January 22, 2025 13:13
@bryanmontz
Copy link
Contributor Author

The test job is failing for some reason. I updated my machine to macOS 15.2, so I can no longer run Xcode 15.4 like the pipeline is running. The tests pass for me locally with Xcode 16.1. Could someone with Xcode 15.4 help me understand the issue?

@Chardot
Copy link

Chardot commented Jan 22, 2025

@bryanmontz Excellent work! I'm excited to see this live in the app 🚀

@joshuatbrown
Copy link
Contributor

👀

@joshuatbrown
Copy link
Contributor

joshuatbrown commented Jan 22, 2025

Build fixed in Xcode 15.4. One of the previews lost a return and apparently Xcode 15.4 didn't like that.

Copy link
Contributor

@joshuatbrown joshuatbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent a good amount of time updating and managing lists, and this is awesome. I'm super happy that we have this in the app and it feels really really good. I did find an issue when I type an entire NIP-05 name, like [email protected], where it takes me to the profile page rather than adding it to the list (or just showing it in the search view). I imagine the same would happen if I pasted (or typed) an npub or maybe an author's hex ID. And I wonder what would happen if I pasted an nevent or an event hex ID.

Still, this is good enough to merge as-is, though I'd love it if we can solve this little issue.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-22.at.12.29.16.mp4

@bryanmontz
Copy link
Contributor Author

@joshuatbrown Thanks for fixing the test build issue! My Xcode (16) said that return wasn't necessary anymore! I forgot I had removed it.

@bryanmontz bryanmontz merged commit 442cb9b into feature/edit-lists-ui Jan 23, 2025
4 checks passed
@bryanmontz bryanmontz deleted the bdm/135-manage-users branch January 23, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants