Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter on id #203

Closed
rizen opened this issue Nov 22, 2024 · 2 comments
Closed

filter on id #203

rizen opened this issue Nov 22, 2024 · 2 comments

Comments

@rizen
Copy link
Member

rizen commented Nov 22, 2024

Because ids are converted to strings publicly, you can't currently create a filter that uses the numeric ID, like a ticket number or whatever. So we need a way to flag an id as public, so it will automatically add it to the meta and allow it to be filtered using the normal filtering mechanisms.

see also: plainblack#29

@rizen
Copy link
Member Author

rizen commented Jan 13, 2025

My current thought is that I should get rid of baseSchemaProps and instead make each of those props their own variable.

This allows developers to make their own custom variants of these fields at import.

So to fix this problem, assuming we have a new property called publicFiltered or some such. Then you could do:

  { 
  ...baseIdField,
  publicFiltered: true,
  }

rizen added a commit that referenced this issue Jan 13, 2025
* Fixed: filter on id #203
* Fixed: How to do a search for hardware ticket by ticket number? #29
@rizen
Copy link
Member Author

rizen commented Jan 13, 2025

fixed by:

  • Set filterQualifier to true for the baseSchemaId.
  • Adding allowRealPubicId to ving schema props.

@rizen rizen closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant