From 10f4eeccea33ac939f1771a7e207a1e221130597 Mon Sep 17 00:00:00 2001 From: Taslan Graham Date: Fri, 17 Jan 2025 10:55:05 -0500 Subject: [PATCH] pkp/pkp-lib#10792 Update ORCiD brand guideline --- .../Form/fields/FieldOrcid.stories.js | 3 +++ src/components/Form/fields/FieldOrcid.vue | 19 ++++++++++--- src/components/Form/mocks/field-orcid.js | 1 + src/components/Icon/Icon.vue | 2 ++ .../Icon/icons/OrcidUnauthenticated.vue | 27 +++++++++++++++++++ .../contributors/ContributorsListPanel.vue | 1 + .../users/SelectReviewerListItem.vue | 8 ++++-- 7 files changed, 56 insertions(+), 5 deletions(-) create mode 100644 src/components/Icon/icons/OrcidUnauthenticated.vue diff --git a/src/components/Form/fields/FieldOrcid.stories.js b/src/components/Form/fields/FieldOrcid.stories.js index 2bca8bd31..d54f1dc20 100644 --- a/src/components/Form/fields/FieldOrcid.stories.js +++ b/src/components/Form/fields/FieldOrcid.stories.js @@ -52,6 +52,7 @@ export const WithOrcid = { ...FieldBaseMock, ...FieldOrcidMock, orcid: 'https://sandbox.orcid.org/0009-0009-3222-5777', + orcidDisplayValue: 'https://sandbox.orcid.org/0009-0009-3222-5777', isVerified: true, }, }; @@ -61,5 +62,7 @@ export const WithUnverifiedOrcid = { ...FieldBaseMock, ...FieldOrcidMock, orcid: 'https://sandbox.orcid.org/0009-0009-3222-5777', + orcidDisplayValue: + 'https://sandbox.orcid.org/0009-0009-3222-5777 (unauthenticated)', }, }; diff --git a/src/components/Form/fields/FieldOrcid.vue b/src/components/Form/fields/FieldOrcid.vue index 9c2f566a8..e23b6fa09 100644 --- a/src/components/Form/fields/FieldOrcid.vue +++ b/src/components/Form/fields/FieldOrcid.vue @@ -27,10 +27,18 @@ class="h-6 w-6" :inline="true" /> + +
tag for HTML display * @returns {string} */ - orcidDisplayValue: function () { + orcidDisplayText: function () { if (this.hasOrcid) { - return `${this.orcidValue}`; + return `${this.orcidDisplayValue}`; } else { return this.orcidValue; } diff --git a/src/components/Form/mocks/field-orcid.js b/src/components/Form/mocks/field-orcid.js index a08ab562b..83ce930c4 100644 --- a/src/components/Form/mocks/field-orcid.js +++ b/src/components/Form/mocks/field-orcid.js @@ -3,6 +3,7 @@ export default { component: 'field-orcid', label: 'ORCID', orcid: '', + orcidDisplayValue: '', authorId: 1, tooltip: 'ORCID is an independent non-profit organization that provides a persistent identifier – an ORCID iD – that distinguishes you from other researchers and a mechanism for linking your research outputs and activities to your iD. ORCID is integrated into many systems used by publishers, funders, institutions, and other research-related services. Learn more at https://orcid.org.', diff --git a/src/components/Icon/Icon.vue b/src/components/Icon/Icon.vue index 50eb769c2..7bcddf37a 100644 --- a/src/components/Icon/Icon.vue +++ b/src/components/Icon/Icon.vue @@ -85,6 +85,7 @@ import Notifications from './icons/Notifications.vue'; import NotVisible from './icons/NotVisible.vue'; import OpenReview from './icons/OpenReview.vue'; import Orcid from './icons/Orcid.vue'; +import OrcidUnauthenticated from './icons/OrcidUnauthenticated.vue'; import Overdue from './icons/Overdue.vue'; import Paste from './icons/Paste.vue'; import Payment from './icons/Payment.vue'; @@ -228,6 +229,7 @@ const svgIcons = { User, View, Workflow, + OrcidUnauthenticated, }; const props = defineProps({ diff --git a/src/components/Icon/icons/OrcidUnauthenticated.vue b/src/components/Icon/icons/OrcidUnauthenticated.vue new file mode 100644 index 000000000..8bfb03fd6 --- /dev/null +++ b/src/components/Icon/icons/OrcidUnauthenticated.vue @@ -0,0 +1,27 @@ + diff --git a/src/components/ListPanel/contributors/ContributorsListPanel.vue b/src/components/ListPanel/contributors/ContributorsListPanel.vue index ec832a321..129f15629 100644 --- a/src/components/ListPanel/contributors/ContributorsListPanel.vue +++ b/src/components/ListPanel/contributors/ContributorsListPanel.vue @@ -392,6 +392,7 @@ export default { if (field.name === 'orcid') { field.orcid = author['orcid'] ?? ''; field.authorId = author['id']; + field.orcidDisplayValue = author['orcidDisplayValue']; field.isVerified = author['orcidIsVerified'] ?? false; field.orcidVerificationRequested = author['orcidVerificationRequested']; diff --git a/src/components/ListPanel/users/SelectReviewerListItem.vue b/src/components/ListPanel/users/SelectReviewerListItem.vue index 2be349893..24ebfe3f4 100644 --- a/src/components/ListPanel/users/SelectReviewerListItem.vue +++ b/src/components/ListPanel/users/SelectReviewerListItem.vue @@ -45,8 +45,12 @@ class="listPanel__item--reviewer__orcid" target="_blank" > - - {{ item.orcid }} + + {{ item.orcidDisplayValue }}