Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the "Show role title in contributor list" setting in user role settings causes a 500 error #10788

Open
ajnyga opened this issue Jan 9, 2025 · 1 comment
Assignees
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Milestone

Comments

@ajnyga
Copy link
Collaborator

ajnyga commented Jan 9, 2025

Describe the bug
A 500 error in the current development version of OxS when saving user role settings with a specific selection:

[500]: POST /ojs/index.php/publicknowledge/$$$call$$$/grid/settings/roles/user-group-grid/update-user-group - Uncaught PDOException: SQLSTATE[HY000]: General error: 1366 Incorrect integer value: 'on' for column 'show_title' at row 1 in /www/ojs/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Database/Connection.php:596
To Reproduce
Steps to reproduce the behavior:

  • Go to Users & Roles > Roles
  • Edit a Role, remove check from " Show role title in contributor list" > Save
  • Edit the same role again, add check to "Show role title in contributor list" > Save > Error

What application are you using?
OJS current development version

PRs
pkp-lib --> #10797
ojs --> pkp/ojs#4597 [TEST ONLY]

@ajnyga
Copy link
Collaborator Author

ajnyga commented Jan 9, 2025

Edit: the same problem applies to multiple checkbox fields in the form because the values are not cast as bool.

Also when adding a new role, the name of the role is not saved and the existing names can not be edited.

Sorry if I just bumped into some unfinished work!

@touhidurabir touhidurabir self-assigned this Jan 13, 2025
@asmecher asmecher added this to the 3.5 Internal milestone Jan 13, 2025
@touhidurabir touhidurabir added the Bug:2:Moderate A bug that is causing problems for a substantial minority of users. label Jan 14, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 14, 2025
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 14, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 14, 2025
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Projects
None yet
Development

No branches or pull requests

5 participants