No reviewers returned from the API endoint users/reviewers

[bozana]

S. https://forum.pkp.sfu.ca/t/rest-api-reviewers-list/93608

The API call api/v1/users/reviewers without the parameter 'reviewStage' returns no items, because it is not checked if the parameter 'reviewStage' exists before applying the filter by workflow stage in this line: https://github.com/pkp/pkp-lib/blob/stable-3_4_0/api/v1/users/PKPUserHandler.php#L224.

In 3.3 the function filterByReviewStage() takes only one stage. This seems to be changed in 3.4, so that the function filterByWorkflowStageIds() takes an array, however the parameter is still only one stage and not an array.

PRs:
stable-3_4_0:

• pkp/pkp-lib#10739 getReviewers(): check if param reviewStage exists f… #10740
• pkp/pkp-lib#10739 submodule update ##bozana/10739-3_4_0##  ojs#4567 (only submodule update)
• pkp/pkp-lib#10739 submodule update ##bozana/10739-3_4_0## omp#1801 (only submodule update)
• pkp/pkp-lib#10739 submodule update ##bozana/10739-3_4_0## ops#838 (only submodule update)

main:

• pkp/pkp-lib#10739 getReviewers(): check if param reviewStage exists f… #10791

[bozana]

Hi @ewhanson, could you please review the fix above?
Thanks a lot!

[bozana]

Hi @ewhanson, maybe just a reminder: if you could review the fix above?
Thanks a lot!

[ewhanson]

Hi @bozana, apologies for the delay. Looks good to me.