Refactor/remove unused functions params and values to improve code readability and performance #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diogomene is attempting to deploy a commit to the Piqnt Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done?
Unused values (constants, function parameters, or enums) have been removed from the project's source code. Detection was carried out using Qodana, and the corresponding SARIF file is attached for reference.
Each flagged occurrence was carefully reviewed. Many of the unused parameter issues were due to adherence to interface contracts or abstract class method signatures. While it would be possible to address these repeated unused implementations by replacing abstract methods with non-abstract methods containing default implementations, such structural changes were intentionally avoided in this update to preserve the integrity of the existing method signatures.
Before each commit, tests were executed, and the build was successfully completed.
Evidences?
qodana.sarif.json
Resolve #298